-
Notifications
You must be signed in to change notification settings - Fork 1
feat/migrate-antd5-remove-style-import-codemo #516
feat/migrate-antd5-remove-style-import-codemo #516
Conversation
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
cjs-builder/index.ts
Outdated
@@ -28,7 +48,8 @@ | |||
const options: Parameters<typeof esbuild.build>[0] = { | |||
entryPoints: [relativeInputFilePath], | |||
bundle: true, | |||
packages: 'external', | |||
// packages: 'external', | |||
external: getExternal(packageJSON), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually we might pass the external package names as the yargs options to the CJS builder OR
We actually remove both packages
and external
and allow esbuild
to bundle the normal dependencies. We will have to move all dependencies
to devDependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let do this one
We actually remove both packages and external and allow esbuild to bundle the normal dependencies. We will have to move all dependencies to devDependencies
c116fe8
to
a71ba5f
Compare
cjs-builder/package.json
Outdated
@@ -6,6 +6,7 @@ | |||
"cjs-builder": "./dist/index.js" | |||
}, | |||
"scripts": { | |||
"build": "esbuild ./index.ts --bundle --platform=node --target=node16 --format=esm --outfile=./dist/index.js --external:esbuild", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not tsc
?
@@ -3,6 +3,9 @@ import esbuild from 'esbuild'; | |||
import { mkdir, readFile, writeFile } from 'node:fs/promises'; | |||
import { dirname, join } from 'node:path'; | |||
|
|||
// list of packages that should be bundled to the codemod (e.g codemod internal utils) | |||
const EXTERNAL_DEPENDENCIES = ['jscodeshift', 'ts-morph']; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm what about @intuita-inc/filemod
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we only import types from it, so its fine
No description provided.